Bugfix/13068 dragdrop widgets #17421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bugfix/13068-dragdrop-widgets
|
Please fix the build |
That test error was unrelated from this PR. |
sebastienros
approved these changes
Jan 30, 2025
|
Anything we're waiting for here after the approve, or can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing my contribution made during Harvest 2024.
This PR is proposing a solution for #13068.
It takes in account settings of bagparts and flowparts during drag & drop of widgets. In case widget is not allowed in target flow/bag, it returns to original location. This way, it is ensured that no misplacement and eventual loss of widget happens.
Please take in consideration, that it was done under time pressure and feel free to suggest changes leading to more coherent code according to rest of OC code-style.