Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TheTheme #3204

Merged
merged 7 commits into from
Dec 17, 2020
Merged

Update TheTheme #3204

merged 7 commits into from
Dec 17, 2020

Conversation

TFleury
Copy link
Contributor

@TFleury TFleury commented Feb 18, 2019

Allow easy "brand" overriding and clean CSS.

@hishamco
Copy link
Member

I think I need to test this one after merge #4069

@agriffard
Copy link
Member

Please solve the conflicts @TFleury

No need of "row" class that causes content overflow outside of container.
Easier to customize with a Template override
- Footer rule could have side effects with footer placed in a content item for exemple
- Remove unnecessary rules
@TFleury
Copy link
Contributor Author

TFleury commented Dec 23, 2019

Please solve the conflicts @TFleury

@agriffard Done

@agriffard agriffard requested a review from Skrypt December 17, 2020 15:32
Copy link
Contributor

@Skrypt Skrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart the small eof

@agriffard agriffard merged commit 0607ee8 into OrchardCMS:dev Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants