-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress testing #4232
Cypress testing #4232
Conversation
7367ca0
to
6d00a3f
Compare
0a3d5b6
to
68063b8
Compare
@sebastienros What do you think about writing a npm package for the generic functions and publishing it as a seperate npm package ? This would allow people that write sites with OC to easily write e2e tests for their sites by reusing some of our functions to interact with the admin UI ? |
995ef8c
to
9d1f3a5
Compare
No new npm package to maintain. Not soon at least. One more thing to maintain, publish, take PRs on ... |
cf849d7
to
e153579
Compare
I think I will revive this PR. Maybe split the work of adding id's, classes or data attributes to elements of the admin UI in smaller Pr's to keep this one targeted. |
I am writing a set of commands / utilities for Cypress in a separate package that can be shared between projects. |
fe59919
to
6d50dcc
Compare
This is ready for review. Need to investigate why the site(s) do not run in https. Once this is merged, I will make other smaller pr's that improve the selectors of the admin interface along with implementing supporting commands in https://github.com/jptissot/cypress-orchardcore |
I will need to try it to review it. Might take some time. |
@jptissot just a very late question why you choose Cypress over normal ASP.NET Core testing? Is it access the HTML elements or is there something further I don't aware of Thanks |
We have unit tests, integration tests coming from ASP.NET Core testing. But we use https://github.com/puppeteer/puppeteer to run functional (e2e) tests. I think Cypress is just pushing those functional test one step further. |
Thanks Jasmin, is it something like Selenium? |
5d018be
to
764ebc8
Compare
54b7268
to
ce69c53
Compare
9b5ef68
to
b1578fa
Compare
Todo
|
On the OrchardCore.sln file there's a solution folder in which we should remove the old linked files and instead add the Cypress tests. |
Maybe there is a better way to do this, but the cypress runner does not currently support paging.
Include commands in this project Add vistual studio solution
afb446d
to
ed28ee3
Compare
Having fun with some e2e testing using Cypress