Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contained Content Item Routing #5455

Closed
wants to merge 3 commits into from

Conversation

deanmarcussen
Copy link
Member

Fixes #2688

WIP

Introduces a Container Routing Part which provides routes for contained items, like taxonomies, and bag items.

Includes compromises to achieve this, however is achievable, and can provide clean routes, e.g. for a taxonomy /categories/travel/some-place

Will demo and see what everyone thinks

Currently there's also a lot of code duplication between autoroute and container route, so would look to resolve some of that later

@jtkech For info I abstracted the transformer rather than using multiple transformers, as the catchall pattern could only be used by one transformer, or if a catchall, and a not quite catchall transformer used, a third not quite catchall transformer couldn't be used.

# Conflicts:
#	OrchardCore.sln
#	src/OrchardCore.Modules/OrchardCore.Contents/Controllers/ItemController.cs
@mawendel
Copy link

mawendel commented Feb 4, 2020

Great Dean, this was exactly what i was looking for a little while back!

@jtkech
Copy link
Member

jtkech commented Feb 4, 2020

@deanmarcussen

Okay makes sense, so a kind of composite transformer, let me know if you have any problem ;)

@deanmarcussen
Copy link
Member Author

Okay makes sense, so a kind of composite transformer, let me know if you have any problem ;)

Yes, kind of @jtkech - not totally, because a transformer would check better for ambiguous matches, where these providers rely on check for duplicates before adding entries.

I chose not to make it async, because our IAutorouteEntries pattern, doesn't need it, and performance... but let me know if you think it would be better to be async by default (as the transformer's do use ValueTask)

@deanmarcussen
Copy link
Member Author

Replaced by #5665 as was easier than dealing with the merge conflicts.

Leaving this branch intact, but pr closed

@agriffard agriffard deleted the deanmarcussen/contained-routing branch May 11, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find a way to display contained content items
3 participants