Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control MarkdownOptions via appsettings #7471

Merged
merged 9 commits into from
Nov 5, 2020

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Nov 1, 2020

Related to PR #7443

/cc @deanmarcussen

@hishamco hishamco requested a review from agriffard November 1, 2020 21:08
@agriffard
Copy link
Member

I was specifically talking about the Configure method that takes a string with extensions separated by +:
https://github.com/lunet-io/markdig/blob/751c79fce4e92857f861d8af0854a8eff0b29071/src/Markdig/MarkdownExtensions.cs#L539

@hishamco
Copy link
Member Author

hishamco commented Nov 1, 2020

I was specifically talking about the Configure method that takes a string with extensions separated by +

I knew that, after that, the dialog goes to appsetting. Am I right?

#7443 (comment)

@agriffard
Copy link
Member

The whole goal for me was to be able to enable any extensions with only one appsetting property, not to create one property for all the possible extensions.

@hishamco
Copy link
Member Author

hishamco commented Nov 1, 2020

to enable any extensions with only one appsetting property

What if someone want to enable Emoji and keep html disabled?

@agriffard
Copy link
Member

What if someone want to enable Emoji and keep html disabled?

nohtml+emojis

@hishamco
Copy link
Member Author

hishamco commented Nov 1, 2020

I got what you meant, seems I misunderstood you from the beginning ;) I will update the PR

@hishamco
Copy link
Member Author

hishamco commented Nov 1, 2020

@agriffard seems we need to point to all possible values or features that could be used in the docs

@agriffard
Copy link
Member

@agriffard seems we need to point to all possible values or features that could be used in the docs

We could add a table with each extension/description in the OrchardCore.Markdown documentation.

@hishamco
Copy link
Member Author

hishamco commented Nov 1, 2020

We could add a table with each extension/description in the OrchardCore.Markdown documentation

Could be, but we need to reduce the effort of updating the docs whenever an extension is added or removed, IMHO point to that function may useful, but all the options are open

@deanmarcussen
Copy link
Member

We could add a table with each extension/description in the OrchardCore.Markdown documentation.

Looks good, just needs docs.

@agriffard agriffard merged commit 84ac3aa into dev Nov 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the hishamco/markdown-features-settings branch November 5, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants