Introduce Culture Scope

[hishamco]

It's related to the PR #7528 and my comments there

[jtkech]

@hishamco i will approve your PR

But just one thing, i don't see any usage of these 2 public properties

[hishamco]

I point to where it's used, also we might to expose the original culture because may it's useful in some cases

[hishamco]

But just one thing, i don't see any usage of these 2 public properties

@jtkech it's used here

[jtkech]

First, based on the removed line, here maybe cultureScope.UICulture

Okay, so you also use the culture scope as a CultureInfo helper to get a cultureInfo from a string

Then because the culture scope set the async local cultures you can just use CultureInfo.CurrentUICulture, that's the goal of this scope to set cultures that can be retrieved from everywhere called in the context of this scope

        using (CultureScope.Create(CultureInfo.GetCultureInfo(culture)))
        {
            // using DefaultPluralRuleProvider to test it returns correct rule
            TryGetRuleFromDefaultPluralRuleProvider(CultureInfo.CurrentUICulture, out var rule);

Or if you want to keep the helper part creating a cultureInfo from a string

        using (CultureScope.Create(culture))
        {
            // using DefaultPluralRuleProvider to test it returns correct rule
            TryGetRuleFromDefaultPluralRuleProvider(CultureInfo.CurrentUICulture, out var rule);

[hishamco]

First, based on the removed line, here maybe cultureScope.UICulture

Ok, but it's the same in this case

Okay, so you also use the culture scope as a CultureInfo helper to get a cultureInfo from a string

There's already an overload to do that

[jtkech]

Okay will see tomorrow if it is not yet merged ;)

The main thing is that you are using a scope to set the static async local CultureInfo properties, and then for your tests in place of retrieving these values from this same async local CultureInfo you are retrieving them from the scope you just created, so here you just test the properties of this scope, you are not testing what it is intended to do.

E.g. when using this scope for liquid rendering (when not in a real view context), the template rendering will still retrieve the cutures from the static CultureInfo, that's the goal

[hishamco]

I may add some unit tests

[hishamco]

E.g. when using this scope for liquid rendering (when not in a real view context)

@jtkech no need to test a fake ILiquidTemplateManager this unit tests ensures if the Render throws an exception it will restore the original cultures