Allow ShapeMetadata access in liquid #8024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and allow to render IHtmlContent with shape_render filter
agriffard
changed the title
jtkech
approved these changes
Dec 17, 2020
| @@ -124,7 +124,8 @@ static async ValueTask<FluidValue> Awaited(Task<IHtmlContent> task) | |||
| return new HtmlContentValue(await task); | |||
| } | |||
|
|
|||
| if (input.ToObjectValue() is IShape shape) | |||
| var shape = input.ToObjectValue(); | |||
| if (shape != null) | |||
There was a problem hiding this comment.
I would suggest to check if it is an IShape or an IHtmlContent
But i saw that it is checked in IHtmlContent CoerceHtmlString(object value)
And if it is another object type, we return StringHtmlContent(value.ToString())
So that's okay ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and allow to render IHtmlContent with shape_render filter
Fixes #8021