Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login Title #8028

Merged
merged 3 commits into from
Dec 16, 2020
Merged

Login Title #8028

merged 3 commits into from
Dec 16, 2020

Conversation

agriffard
Copy link
Member

@agriffard agriffard commented Dec 16, 2020 •
edited
Loading

Use the name of the site in the Login title.

image

Fixes #8027

@agriffard agriffard requested a review from jptissot December 16, 2020 15:02
hishamco
hishamco approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@hishamco hishamco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the spelling is correct so LGTM

@hishamco
Copy link
Member

Why Linux build is failing?!!

@Skrypt
Copy link
Contributor

Skrypt commented Dec 16, 2020

Can you change the external login title too while we're at it?

@agriffard
Copy link
Member Author

agriffard commented Dec 16, 2020 •
edited
Loading

Can you change the external login title too while we're at it?

What would it be?

@Skrypt
Copy link
Contributor

Skrypt commented Dec 16, 2020 •
edited
Loading

@T["Use another service to log in to {0}.", Site.SiteName]

@Skrypt
Copy link
Contributor

Skrypt commented Dec 16, 2020

I don't like the fact that it wraps on 2 lines because of the long title but it is what it is. LGTM.

@agriffard agriffard merged commit bf6efb1 into dev Dec 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the ag/login branch December 16, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamco hishamco hishamco approved these changes

@jptissot jptissot Awaiting requested review from jptissot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login screen
3 participants
@agriffard @hishamco @Skrypt