Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tenants buttons #8131

Merged
merged 3 commits into from
Dec 24, 2020
Merged

Tenants buttons #8131

merged 3 commits into from
Dec 24, 2020

Conversation

agriffard
Copy link
Member

@agriffard agriffard commented Dec 23, 2020 •
edited
Loading

image

@hishamco
Copy link
Member

@agriffard did the team agreed to use the buttons again? Because using many colors is confusing and doesn't make sense, there should be a set of colors according the color scheme of the theme

@agriffard
Copy link
Member Author

People seem to be used to Bootstrap buttons and colors.

@hishamco
Copy link
Member

I don't have issue with the buttons, but introducing more colors without meaning doesn't make sense, that's my point

@deanmarcussen
Copy link
Member

I'm not a fan of the slider icon for the disable / enable.

It suggests you can swipe it, as if it was a checkbox selector.

What about tick and cross?

@agriffard
Copy link
Member Author

image

@agriffard
Copy link
Member Author

Ok, no more icons.
Screenshot updated in first comment.

@agriffard agriffard merged commit b5c5ad0 into dev Dec 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the ag/uitenants branch December 24, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agriffard @hishamco @deanmarcussen