Fix Auth Logs on Setup & GetSettings in Steps (Lombiq Technologies: OCORE-46) #8636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piedone
reviewed
Feb 19, 2021
src/OrchardCore.Modules/OrchardCore.Facebook/Login/Configuration/FacebookLoginConfiguration.cs
Show resolved
Hide resolved
Piedone
requested changes
Feb 19, 2021
src/OrchardCore.Modules/OrchardCore.GitHub/Configuration/GithubOptionsConfiguration.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Twitter/Signin/Configuration/TwitterOptionsConfiguration.cs
Outdated
Show resolved
Hide resolved
jtkech
changed the title
Piedone
reviewed
Feb 21, 2021
src/OrchardCore.Modules/OrchardCore.Twitter/Signin/Configuration/TwitterOptionsConfiguration.cs
Show resolved
Hide resolved
Piedone
approved these changes
Feb 22, 2021
Skrypt
reviewed
Feb 22, 2021
src/OrchardCore.Modules/OrchardCore.GitHub/Configuration/GithubOptionsConfiguration.cs
Show resolved
Hide resolved
Skrypt
reviewed
Feb 22, 2021
...rdCore.Modules/OrchardCore.Google/Authentication/Configuration/GoogleOptionsConfiguration.cs
Outdated
Show resolved
Hide resolved
Skrypt
reviewed
Feb 22, 2021
...s/OrchardCore.Microsoft.Authentication/Configuration/MicrosoftAccountOptionsConfiguration.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6741 related to azureAD, but here for all authentication features, twitter, google, github ...
Prevent logging warnings on setup.
Use
LoadSettings()in place ofGetSettings()for updating the settings in the related recipe steps. The authentication settings being entities held by theSiteSettingsdocument, so as done in other places and for all shared documents.