Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove monaco dev build files #9041

Merged

Conversation

MichaelPetrinolis
Copy link
Contributor

remove dev build js files from Resources.
Should we also remove the js map files and/or rename the monaco folders (remove the min folder under monaco)?
Map files are ~10MB uncompressed.

@Skrypt
Copy link
Contributor

Skrypt commented Apr 2, 2021

Unless these map files are generated by our own gulpfile.js they are unecessary. The problem is that if any changes are made then the .map files will not be updated. We should not update these assets so keeping the .map files is unecessary.

@MichaelPetrinolis
Copy link
Contributor Author

@Skrypt these are the map files distributed with monaco editor and copied from node_modules through assets.json pipeline. But I agree they are unnecessary.

@agriffard agriffard requested a review from Skrypt April 8, 2021 09:59
@MichaelPetrinolis
Copy link
Contributor Author

@Skrypt Monaco has its own AMD loader to handle its resources. I think that if we create the *.min.js versions it will not work, as it will keep requesting the *.js files and not the *.min.js. Also @sebastienros suggested to remove source files in #8266 (comment)

@agriffard agriffard merged commit 540de8c into OrchardCMS:dev Apr 9, 2021
@MichaelPetrinolis MichaelPetrinolis deleted the remove_monaco_dev_build_files branch July 23, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants