Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #602, #573 icon asclepius svg #604

Merged
merged 14 commits into from
Mar 28, 2024
Merged

Fixes #602, #573 icon asclepius svg #604

merged 14 commits into from
Mar 28, 2024

Conversation

codeGlaze
Copy link

@codeGlaze codeGlaze commented Mar 11, 2024 •
edited
Loading

Description:

Added Rod of Asclepius icon: fixes #602

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

codeGlaze added 14 commits June 24, 2020 21:53
@codeGlaze
Merge remote-tracking branch 'DMV-orcpub/develop' into develop
8a56459
@codeGlaze
Merge remote-tracking branch 'DMV-orcpub/develop' into develop
a1e80c9
@codeGlaze
Merge remote-tracking branch 'DMV-orcpub/develop' into develop
e6f8543
@codeGlaze
Merge remote-tracking branch 'Orcpub/develop' into develop
6c13e07
@codeGlaze
Merge remote-tracking branch 'DMV-orcpub/develop' into develop
e54184d
@codeGlaze
Merge remote-tracking branch 'DMV-orcpub/develop' into develop
d55014a
@codeGlaze
Merge remote-tracking branch 'origin/develop' into develop
3c588ba
@codeGlaze
Merge remote-tracking branch 'Orcpub/develop' into develop
6f812b4
@codeGlaze
Merge remote-tracking branch 'Orcpub/develop' into develop
bf23375
@codeGlaze
Merge remote-tracking branch 'origin/develop' into develop
2e2e41b
@codeGlaze
Merge remote-tracking branch 'DMV-orcpub/develop' into develop
965df3e
@codeGlaze
Merge remote-tracking branch 'upstream/develop' into develop
89564a2
@codeGlaze
Merge remote-tracking branch 'upstream/develop' into develop
98573d8
@codeGlaze
Fixes Orcpub#602 - minor - SVG icon swap
5dc7f02 
minor
+ adds svg icons for rod-of-asclepius
+ changes CON icon to RoA
+ added some basic documentation to relevant functions
@codeGlaze codeGlaze changed the title #602 fix icon asclepius svg Fixes #602, #573 icon asclepius svg Mar 11, 2024
Jessomadic
Jessomadic approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@Jessomadic Jessomadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as well

@datdamnzotz datdamnzotz merged commit d57501d into Orcpub:develop Mar 28, 2024
1 check passed
@datdamnzotz datdamnzotz added this to the 2.5.0.25 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jessomadic Jessomadic Jessomadic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0.25
Development

Successfully merging this pull request may close these issues.

Constitution score uses Caduceus instead of Rod of Asclepius for imagery
3 participants
@codeGlaze @Jessomadic @datdamnzotz