OMG-25427 - Set SHIPPO-ACCOUNT-ID header #7
Conversation
Good idea! I made the changes in this PR and am in the process of updating the shipping-service PR. |
client/client.go
Outdated
| // add any passed in headers | ||
| if headers != nil { | ||
| for k, v := range headers { | ||
| c.logPrintf("Client.createRequest() setting header: key=%q, value=%q", k, v) |
There was a problem hiding this comment.
might want to relocate the c.logPrintf to the defer func above, looks like logging is only done if the logger isn't nil
There was a problem hiding this comment.
Done, but logPrintf also checks if logger is nil.
…nt, UpdateCarrierAccount, or ConnectCarrierAccount
…ierAccount, UpdateCarrierAccount, or ConnectCarrierAccount" This reverts commit 65e1b60.
…he value is not empty
client/tracking_status.go
Outdated
| @@ -8,7 +8,7 @@ import ( | |||
| ) | |||
|
|
|||
| // GetTrackingUpdate requests the tracking status of a shipment. | |||
| func (c *Client) GetTrackingUpdate(carrier, trackingNumber string) (*models.TrackingStatus, error) { | |||
| func (c *Client) GetTrackingUpdate(carrier, trackingNumber string, shippoSubAccountID string) (*models.TrackingStatus, error) { | |||
There was a problem hiding this comment.
i don't think we'll need subaccount here, there's a carrier but it's usps not the carrier id: https://docs.goshippo.com/shippoapi/public-api/#operation/GetTrack
@ilyutov This is the strategy we went with. Please review when you have a chance. |
OMG-25427
Update to support the
SHIPPO-ACCOUNT-IDheader required for Shippo's new sub-account system.Related PR: