Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usePositionStream not refreshing algo orders with current refresh function #3

Closed
Veenoway opened this issue Sep 23, 2024 · 1 comment

Comments

@Veenoway
Copy link
Contributor

Veenoway commented Sep 23, 2024

ISSUE:

Actually the usePositionStream got a refresh function that will refresh the fetch "/v1/positions".

It isn't refreshing the useOrderStream included in the usePositionStream hook.

This will lead to an issue after a long inactivity on the app, algo orders won't be retrigger so it will show current position but algo orders won't be return updated if the user add a new TP SL.

FIX:
Adding a custom function who will execute refresh function from useOrderStream & refresh function from "/v1/positions".

Veenoway added a commit to Veenoway/orderly-js-sdk that referenced this issue Sep 23, 2024
@Veenoway Veenoway changed the title usePositionStream not refreshing algo orders usePositionStream not refreshing algo orders with current refresh function Sep 29, 2024
@Tarnadas
Copy link
Member

Tarnadas commented Oct 8, 2024

Thx for this issue and fix!

It is eligible worth 100 points for Dev Maxi role:
OrderlyNetwork/Dev-Maxi#3

I will close this, but the commit will be added to our repo once merged on Gitlab

@Tarnadas Tarnadas closed this as completed Oct 8, 2024
Tarnadas pushed a commit that referenced this issue Oct 8, 2024
fix: issue #3

See merge request orderlynetwork/orderly-fe/orderly-web!62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants