Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STIL Parser update to make vector inline comment a child of vector node #206

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

rlaj
Copy link
Member

@rlaj rlaj commented Aug 12, 2024

Comment node of vector inline comment (defined as inline comment between end of vector and a newline) to be a child node of the vector node. Allows better comment traceability for downstream AST processors.

EXAMPLE STIL:

V { Jtag=1110x; }   // vecLine:1, testCycle:1
// SELECT_DR -> SELECT_IR
V { Jtag=1p10x; }   // vecLine:2, testCycle:2
// SELECT_IR -> CAPTURE_IR

PREVIOUS:

    Vector
        CyclizedData
            SigRefExpr
                String("Jtag")
            Data("1110x")
    Comment("// vecLine:1, testCycle:1")
    Comment("// SELECT_DR -> SELECT_IR")
    Vector
        CyclizedData
            SigRefExpr
                String("Jtag")
            Data("1p10x")
    Comment("// vecLine:2, testCycle:2")
    Comment("// SELECT_IR -> CAPTURE_IR")

UPDATED:

    Vector
        CyclizedData
            SigRefExpr
                String("Jtag")
            Data("1110x")
        Comment("// vecLine:1, testCycle:1")
    Comment("// SELECT_DR -> SELECT_IR")
    Vector
        CyclizedData
            SigRefExpr
                String("Jtag")
            Data("1p10x")
        Comment("// vecLine:2, testCycle:2")
    Comment("// SELECT_IR -> CAPTURE_IR")

@rlaj rlaj requested review from ginty, priyavadan and coreyeng August 12, 2024 22:38
Copy link
Member

@coreyeng coreyeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't been using STIL here yet, but I don't see any issue.

@rlaj rlaj merged commit faa2247 into master Aug 14, 2024
11 of 12 checks passed
@rlaj rlaj deleted the feature/stil_vector_inline_comment branch August 14, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants