Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STIL - ignore include statements, in-line loop comments, #208

Closed
wants to merge 32 commits into from

Conversation

rlaj
Copy link
Member

@rlaj rlaj commented Oct 4, 2024

This PR includes two updates (in addition to merging updates from master branch):

  1. New function to parse STIL into AST that ignores include statements

  2. Loop comments - comments on loop line are now in node that is child of loop node

EXAMPLE STIL:

  Loop 5    { V { group1=0p11T;  } } // vecLine:6, testCycle:6
  // COMMENT
  Loop 3    { V { group1=0p10t;  } } // vecLine:7, testCycle:11
  // COMMENT

PREVIOUS:

        Loop(5)
            Vector
                CyclizedData
                    SigRefExpr
                        String("group1")
                    Data("0p11T")
        Comment("// vecLine:6, testCycle:6")
        Comment("// COMMENT")
        Loop(3)
            Vector
                CyclizedData
                    SigRefExpr
                        String("group1")
                    Data("0p10t")
        Comment("// vecLine:7, testCycle:11")
        Comment("// COMMENT")

UPDATED:

        Loop(5)
            Vector
                CyclizedData
                    SigRefExpr
                        String("group1")
                    Data("0p11T")
            Comment("// vecLine:6, testCycle:6")
        Comment("// COMMENT")
        Loop(3)
            Vector
                CyclizedData
                    SigRefExpr
                        String("group1")
                    Data("0p10t")
            Comment("// vecLine:7, testCycle:11")
        Comment("// COMMENT")

@rlaj rlaj requested review from ginty and priyavadan October 4, 2024 12:23
@ginty
Copy link
Member

ginty commented Oct 4, 2024

LGTM, but not really an AMD-special, so should the PR not be to the master branch and then we can later merge that into AMD?

@rlaj rlaj changed the title STIL - ignore import statements, in-line loop comments, STIL - ignore include statements, in-line loop comments, Oct 4, 2024
@rlaj
Copy link
Member Author

rlaj commented Oct 4, 2024

Yeah, was debating it and I guess I chose poorly, lol. Will move it over to master.

@rlaj rlaj closed this Oct 4, 2024
@rlaj rlaj deleted the feature/stil_ignore_incl branch January 22, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants