-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Dropped & Replaced Transactions #259
Comments
In the meantime... Until the transaction is confirmed, we could continue watching the blockchain for additional transactions that are signed by the original wallet & see if they look like replacements. Doesn't seem too hard. |
From my research when a client wants to increase gas it creates another transactions with higher gas price and the same nonce. Now the problem is that the web3 browser / Metamask do not communicate this back to the Dapp. There are some proposed solutions (that Micah outlined above) but nothing we could use today. I see 2 ways we could get this done:
Personally I think the option 2 is not so messy and doable relatively quickly and would vote for that one if we want to have this functionality reasonably quickly. Actually I see that Etherscan allows 1 request every 5 seconds to their api without the need for an API key. That is more than enough to get the latest 20 transactions of an account and check for possible gas price upgrade transaction. |
I would suggest to subscribe to new transactions using WS provider and adding a |
That might be even more elegant, thanks @shahthepro ! |
PR for this issue: #304 |
If a user decides to "speed up" her transaction by submitting a second one with the same none and a higher gas price, our DApp is unaware of the new transaction and gets stuck waiting for the old one. This is a common problem with no simple solution yet.
See the following:
The text was updated successfully, but these errors were encountered: