Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle dropped and replaced transactions v 2.0 #483

Open
sparrowDom opened this issue Jan 6, 2021 · 2 comments
Open

Handle dropped and replaced transactions v 2.0 #483

sparrowDom opened this issue Jan 6, 2021 · 2 comments
Labels
dapp Relating to OUSD.com enhancement New feature or request good first issue Good for newcomers P3 Users are not significantly affected, minor cosmetic issue

Comments

@sparrowDom
Copy link
Member

sparrowDom commented Jan 6, 2021 •
edited
Loading

For the transaction side bar view in the /mint part of the dapp we already implemented the logic so that the dapp is able to handle dropped&replaced transactions --> see issue & PR

It would be cool if we could develop a utility function that can listen for transaction being mined (replacing this part), and also be able to handle that transaction being dropped and replaced / speed up with more gwei.

We could then use that on parts of the dapp not yet supporting it:

  • approve stable coin before minting
  • staking OGN
  • claiming staked OGN
  • claiming OGN compensation
  • claiming OUSD compensation
@sparrowDom sparrowDom added dapp Relating to OUSD.com enhancement New feature or request good first issue Good for newcomers labels Jan 6, 2021
@micahalcorn micahalcorn added the P3 Users are not significantly affected, minor cosmetic issue label Feb 2, 2021
@micahalcorn
Copy link
Member

micahalcorn commented Sep 6, 2021 •
edited
Loading

I was confused by this today when swapping with one of the AMM contracts. The card on the side was spinning forever after my replacement transaction was confirmed. I suspect that the original update to handle dropped and replaced transactions only works with the Origin Vault transactions? If so, we should add the utility function, as you mentioned, to work with any transactions that go through the DApp.

@sparrowDom
Copy link
Member Author

Yup that is right, it only subscribes to Origin Vault events right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dapp Relating to OUSD.com enhancement New feature or request good first issue Good for newcomers P3 Users are not significantly affected, minor cosmetic issue
Projects
Origin DeFi (OUSD + OETH)
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@micahalcorn @sparrowDom