Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command-line completion support for bash and zsh #61

Merged
merged 3 commits into from
Jul 12, 2020

Conversation

rahuliyer95
Copy link
Collaborator

  • Fixes [Feature] autocomplete run #60
  • Completions available for bash and zsh
  • Don't know how to auto-install with pip. Any help here would be appreciated :)

@OrkoHunter
Copy link
Owner

Hi @rahuliyer95,

Thank you for taking on the feature request. I would also need your help to know how to use change. Could you also please make the following changes? Thanks!

  • Add a section in the README (after Usage section) on how to use these completion scripts.
  • Update Usage section with the new keep command.

@rahuliyer95
Copy link
Collaborator Author

I have updated the README to reflect the steps required to enable TAB completion on the command-line. I don't think the newly added completion command will ever be used by anyone as it outputs the stored commands specific to the shell of choice and has no direct use.

@OrkoHunter
Copy link
Owner

Thanks @rahuliyer95 ! Sounds good that it's fine not to document the command. I will get back on this.

Copy link
Owner

@OrkoHunter OrkoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rahuliyer95 ! This looks good to me. Can you please resolve the README conflict and merge by yourself?

I moved README.rst to README.md and I'm unable to resolve conflicts in this PR. Sorry for the trouble. :)

@rahuliyer95
Copy link
Collaborator Author

Resolved the conflicts and can be merged

@OrkoHunter OrkoHunter merged commit 2295742 into OrkoHunter:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] autocomplete run
2 participants