This repository has been archived by the owner on Jul 9, 2023. It is now read-only.
Updating Orleans and Cosmos Db Packages and dealing with breaking change #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e introduced in Orleans 3.3.0.
|
My apologies. I just noticed that I said gave the incorrect package versions in the first commit. The actual version updates were 3.0.2 => 3.4.1 for Orleans and 3.6.0 => 3.17.1 for Cosmos Db. 😅 |
| <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.3" /> | ||
| <PackageReference Include="Microsoft.Azure.Cosmos" Version="3.17.1" /> | ||
| <PackageReference Include="Microsoft.Orleans.OrleansRuntime" Version="3.4.1" /> | ||
| <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.4" /> |
There was a problem hiding this comment.
CI broke as this also needs to be updated for test project
|
Apologies for not getting to this sooner, @NickBarrett! I was unable to push updates to your PR branch, so I pushed them to a new PR: #51 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
We have had a go at updating the package references to Microsoft.Azure.Cosmos and Microsoft.Orleans.OrleansRuntime to their current latest versions (3.17.1 and 3.4.1 respectively).
As part of this we had to make some changes to the methods in
CosmosDBGrainStorageto setgrainState.RecordExistsappropriately, as a breaking change was introduced in Orleans 3.3.0.Cheers,
Nick