Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feather diff viewer #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feather diff viewer #5

wants to merge 5 commits into from

Conversation

thdaele
Copy link
Member

@thdaele thdaele commented Feb 25, 2025

Other than the UI it should be finished, if someone wants to help make the UI better, feel free to reach out here or on discord since I am not the greatest at UI

@worldwidepixel
Copy link
Contributor

worldwidepixel commented Mar 8, 2025

Seems perfectly fine? I'd recommend two things out of nitpickyness:

  1. Make the diff inside a div with a max height and scrollbar, so the page doesn't become a kilometre long.
  2. Modify the site CSS to make scrollbar colours match the selected colour scheme of the site.

@thdaele
Copy link
Member Author

thdaele commented Mar 8, 2025

What I personally don't like about it atm is that when there is a lot in the diff. It is hard to see where the list of the classes, methods and fields start. I tried to place them next to each other (and adding individual scrollbar would probs be nice too then) but I ran into my limited knowledge of CSS
Should be addressed in the latest commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants