fix: avoid memory leak by detaching up events

Orphoros · Feb 24, 2024 · 966ada2 · 966ada2
1 parent 2bfea80
commit 966ada2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/App.tsx b/src/App.tsx
@@ -10,6 +10,12 @@ function App() {
 		window.addEventListener('contextmenu', e => {
 			e.preventDefault();
 		}, false);
+
+		return () => {
+			window.removeEventListener('contextmenu', e => {
+				e.preventDefault();
+			}, false);
+		};
 	};
 
 	const correctIpcTime = () => {

diff --git a/src/components/PreviewCard.tsx b/src/components/PreviewCard.tsx
@@ -35,10 +35,7 @@ export default function PreviewCard() {
 		init().catch(console.error);
 	}, []);
 	useEffect(() => {
-		const id = setInterval(() => {
-			const today = new Date();
-			changeTime(today);
-		}, 1000);
+		const id = setInterval(checkTime, 1000);
 		return () => {
 			clearInterval(id);
 		};
@@ -70,8 +67,6 @@ export default function PreviewCard() {
 		changeTime(time);
 	}
 
-	setInterval(checkTime, 1000);
-
 	return (
 		<Card className={`w-[380px] h-[300px] ${showVibrancy ? 'bg-content1  bg-opacity-50' : 'bg-content2'} rounded-2xl`} shadow='none'>
 			<CardHeader>

diff --git a/src/provider/AppProvider.tsx b/src/provider/AppProvider.tsx
@@ -11,7 +11,7 @@ export default function AppProvider({children}: {children: React.ReactNode}) {
 	const [platformName, setPlatformName] = useState<OsType | undefined>(undefined);
 	useLayoutEffect(() => {
 		const init = async () => {
-			await attachConsole();
+			const detachConsole = await attachConsole();
 
 			void debug('initializing app...');
 
@@ -28,6 +28,8 @@ export default function AppProvider({children}: {children: React.ReactNode}) {
 					html.style.removeProperty('background');
 				}
 			}
+
+			detachConsole();
 		};
 
 		init().catch(error);