feat: added forgot password #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josedev-union
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
I merged it to not block you. It has been deployed on staging.
But I am not comfortable with doris introduction here. Why do we not use the default superset database, postgresql? It is much reasonable and easy to maintain in the long term, isn't it? Doris will be the pre-requisite for studio, just for this forgot pwd func.
Instead, we can define reset_user_password here https://github.com/Ortege-xyz/studio/tree/ortege/superset/models
@HariSeldon23 @prodesert22 what are your thoughts on this?
| :param email: | ||
| the user.email to send the Email | ||
| """ | ||
| logger.info(f"email {email}") |
There was a problem hiding this comment.
could you use logger.debug or remove?
| try: | ||
| user_id = user.id | ||
| resetpw = self.get_reset_password_hash(user_id) | ||
| logger.info(f"resetpw {resetpw}") |
| ) | ||
|
|
||
| try: | ||
| logger.info("Sending message") |
| Subject="Reset your Ortege studio password", | ||
| HtmlBody=message_html | ||
| ) | ||
| logger.info("Sent message") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added forgot password feature to work need to add DORIS_HOST, DORIS_USER, DORIS_PASSWORD in superset config
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
ADDITIONAL INFORMATION