-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static dependencies have been removed and replaced by components #20
Conversation
@@ -21,7 +21,8 @@ | |||
], | |||
"require": { | |||
"php": ">=5.3.2", | |||
"symfony/framework-bundle": ">=2.0,<3.0-dev" | |||
"symfony/framework-bundle": ">=2.0,<3.0-dev", | |||
"components/html5-boilerplate": "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should point to version 4.3
or better to 4.3.*
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's impossible because the component has only one master branch without tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems it does: https://packagist.org/packages/components/html5-boilerplate#4.3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You right! I proceed to change.
Great contribution @Gta-Cool, I've added some comments on your code, please take two minutes to review them before I proceed with the merge. I noticed you marked this version as
(https://github.com/h5bp/html5-boilerplate/blob/v4.3.0/CHANGELOG.md) |
@@ -29,7 +30,7 @@ | |||
"target-dir": "Oryzone/Bundle/BoilerplateBundle", | |||
"extra": { | |||
"branch-alias": { | |||
"dev-master": "4.2.x-dev" | |||
"dev-master": "4.3.x-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you fully upgraded the twig template to reflect the new changes introduced by the 4.3 version of h5bp?
Ok, great! No, last night, I forgot to update the twig with 4.3.* changes, I'll make modifications you have told me. Do you agree with the use of jQuery 2.* ? Because the composer.json of "components/html5-boilerplate" have no superior restriction for jquery version, maybe I'll make a PR about it. |
Cool, I can't wait to release this new version of the boilerplate! 😉 For what regards jQuery 2.* i don't agree at all... mostly for the following two reasons:
|
…1.10.2 dependency in composer.json temporarily
:) The twig file has been updated with your recommendantions and I add a dependency to jquery 1.10.2 in composer.json temporarily (the time your pull request is accepted). |
Tested! I can confirm it works (i just only had some issues because https://github.com/robloach/component-installer requires a fresh version of composer) Proceding with merge ;) |
- Static dependencies have been removed and replaced by components (requires a fresh version of composer) - Updated to H5BP 4.3
Great :) |
Hi, I removed the static dependencies in favor of components packages required from composer. I hope you will appreciate my changes.