Fix fatal SSH starting error & correct comment #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a fatal starting error that occurred when obtaining the example server-private-key value. this was removed for another reason, instead of being fixed: using the system SSH rsa key could be considered bad practice due to the insecurities of using the same key twice. in the event someone (maybe by the web gui) gets the key, that same key can be used as a system console assuming SSH was enabled on the host machine.
Osiris-Team
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a fatal starting error that occurred when obtaining the example server-private-key value. this was removed for another reason, instead of being fixed: using the system SSH rsa key could be considered bad practice due to the insecurities of using the same key twice. in the event someone (maybe by the web gui) gets the key, that same key can be used as a system console assuming SSH was enabled on the host machine.