Get the SwaggerSchemaFilter working #1
Conversation
|
Cool, thanks! Will the fix be added to Swashbuckle as well? That is what we are using at work. The change done in Swagger-Net didn't look to overwhelming. |
|
Sorry, i gave up with swashbucle...
The releases are too slow
On Dec 1, 2017 2:18 AM, "Oskar Klintrot" <notifications@github.com> wrote:
Cool, thanks! Will the fix be added to Swashbuckle as well? That is what we
are using at work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAhSwnf8BZ6o8FTsBdF_D8k3_jWi92_iks5s76g8gaJpZM4QxtqY>
.
|
|
To bad but I do understand you. Can I open a PR to Swashbuckle with your fix? Hopefully it will be merged and released eventually... |
|
Or maybe not: domaindrivendev/Swashbuckle.WebApi#445 |
|
Sure you can. |
|
Not really my call to make but your project looks more active than Swashbuckle (it's 2 years since a PR with this fix was opened). |
|
Exactly my point! see that PR 445, it was opened in Jul 2015... I've been trying to keep Swagger-Net as compatible with Swashbuckle as possible, the only major breaking change is the UI, as long as you guys don't have any UI customizations the migration should be just a few minutes. |
|
Yeah, that is painfully slow... But to be fair, the PR owner stopped responding to the reviewer. Nice to hear! If we end up missing anything more in Swashbuckle I will definitely root for Swagger-Net! |
|
I see your PR on Swashbuckle still open... Since then I had more than 10 releases: |
|
I know, it's a joke... |
Switch to Swagger-Net, I made the correction there.
Made some change to the Controller to improve a bit the readability