Switch to HTTPX to address regression in Python 3.10 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oussamaessaji
previously requested changes
Feb 9, 2024
elyousfi5
reviewed
Feb 12, 2024
# Conflicts: # src/ostorlab/cli/scan/run/run.py
benyissa
reviewed
Feb 29, 2024
…h_httpx # Conflicts: # src/ostorlab/agent/kb/KB
deadly-panda
reviewed
Mar 1, 2024
deadly-panda
reviewed
Mar 1, 2024
deadly-panda
reviewed
Mar 1, 2024
deadly-panda
reviewed
Mar 1, 2024
amine3
previously approved these changes
Mar 1, 2024
deadly-panda
previously requested changes
Mar 1, 2024
deadly-panda
reviewed
Mar 1, 2024
# Conflicts: # tests/agent/mixins/agent_report_vulnerability_mixin_test.py # tests/apis/create_asset_test.py # tests/cli/vulnz/list/test_list_vulnz.py
amine3
approved these changes
Mar 1, 2024
3asm
dismissed stale reviews from oussamaessaji and deadly-panda
Comments fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in the following issue python/cpython#110467, we are encountering a regression in python 3.10 and newer versions.
The issue do not appear on
httpx, hence the change.