Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stop/delete scan to accept multiple ids #760

Merged
merged 10 commits into from
Aug 7, 2024

Conversation

oussamaessaji
Copy link
Member

No description provided.

adnaneserrar
adnaneserrar previously approved these changes Jul 29, 2024
@3asm
Copy link
Member

3asm commented Aug 1, 2024

Ping @oussamaessaji on PR.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.27%. Comparing base (e3998b9) to head (d6990a3).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
+ Coverage   62.10%   62.27%   +0.16%     
==========================================
  Files         339      339              
  Lines       14042    14046       +4     
==========================================
+ Hits         8721     8747      +26     
+ Misses       5321     5299      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oussamaessaji oussamaessaji marked this pull request as ready for review August 5, 2024 13:21
src/ostorlab/serve_app/oxo.py Outdated Show resolved Hide resolved
@oussamaessaji oussamaessaji requested a review from 3asm August 5, 2024 16:12
src/ostorlab/serve_app/oxo.py Outdated Show resolved Hide resolved
@oussamaessaji oussamaessaji marked this pull request as draft August 5, 2024 16:51
ostorlab added 2 commits August 6, 2024 14:30
…cept_multiple_ids' into feature/Update_stop_scan_to_accept_multiple_ids
@oussamaessaji oussamaessaji changed the title Update stop scan to accept multiple ids Update stop/delete scan to accept multiple ids Aug 6, 2024
@oussamaessaji oussamaessaji marked this pull request as ready for review August 6, 2024 15:34
src/ostorlab/serve_app/oxo.py Outdated Show resolved Hide resolved
adnaneserrar
adnaneserrar previously approved these changes Aug 7, 2024
@oussamaessaji oussamaessaji merged commit 79e56da into main Aug 7, 2024
12 checks passed
@oussamaessaji oussamaessaji deleted the feature/Update_stop_scan_to_accept_multiple_ids branch August 7, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants