-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stop/delete scan to accept multiple ids #760
Merged
oussamaessaji
merged 10 commits into
main
from
feature/Update_stop_scan_to_accept_multiple_ids
Aug 7, 2024
Merged
Update stop/delete scan to accept multiple ids #760
oussamaessaji
merged 10 commits into
main
from
feature/Update_stop_scan_to_accept_multiple_ids
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnaneserrar
previously approved these changes
Jul 29, 2024
elyousfi5
reviewed
Jul 29, 2024
…can_to_accept_multiple_ids
Ping @oussamaessaji on PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
==========================================
+ Coverage 62.10% 62.27% +0.16%
==========================================
Files 339 339
Lines 14042 14046 +4
==========================================
+ Hits 8721 8747 +26
+ Misses 5321 5299 -22 ☔ View full report in Codecov by Sentry. |
3asm
requested changes
Aug 5, 2024
3asm
requested changes
Aug 5, 2024
…cept_multiple_ids' into feature/Update_stop_scan_to_accept_multiple_ids
oussamaessaji
changed the title
Update stop scan to accept multiple ids
Update stop/delete scan to accept multiple ids
Aug 6, 2024
3asm
requested changes
Aug 6, 2024
adnaneserrar
previously approved these changes
Aug 7, 2024
3asm
approved these changes
Aug 7, 2024
oussamaessaji
deleted the
feature/Update_stop_scan_to_accept_multiple_ids
branch
August 7, 2024 15:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.