Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/exit once the scan has completed #789

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

elyousfi5
Copy link
Member

@elyousfi5 elyousfi5 commented Aug 15, 2024

Screencast.from.2024-08-15.16-32-54.webm

@elyousfi5 elyousfi5 marked this pull request as draft August 15, 2024 15:51
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 62.51%. Comparing base (fb66adb) to head (4b98917).
Report is 5 commits behind head on main.

Files Patch % Lines
src/ostorlab/runtimes/local/runtime.py 61.11% 7 Missing ⚠️
src/ostorlab/runtimes/local/log_streamer.py 50.00% 1 Missing ⚠️
src/ostorlab/runtimes/runtime.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
+ Coverage   62.47%   62.51%   +0.03%     
==========================================
  Files         340      340              
  Lines       14111    14146      +35     
==========================================
+ Hits         8816     8843      +27     
- Misses       5295     5303       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elyousfi5 elyousfi5 marked this pull request as ready for review August 15, 2024 16:07
ohachimOs
ohachimOs previously approved these changes Aug 15, 2024
src/ostorlab/runtimes/local/log_streamer.py Outdated Show resolved Hide resolved
src/ostorlab/runtimes/local/runtime.py Outdated Show resolved Hide resolved
src/ostorlab/runtimes/local/runtime.py Outdated Show resolved Hide resolved
@3asm 3asm merged commit d4139db into main Aug 15, 2024
12 checks passed
@3asm 3asm deleted the fix/exit-once-the-scan-has-completed branch August 15, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants