Fix broken OXO standalone binary #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #799 +/- ##
=======================================
Coverage 62.68% 62.68%
=======================================
Files 340 340
Lines 14210 14210
=======================================
Hits 8907 8907
Misses 5303 5303 ☔ View full report in Codecov by Sentry. |
adnaneserrar
approved these changes
Sep 9, 2024
ErebusZ
approved these changes
Sep 9, 2024
nmasdoufi-ol
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OXObinary was broken since this release v1.0.25 because ofpyaxmlparserlibrary since it is trying to accesspublic.xmlfile but it is missingIn this pull request, I'm adding
--collect-all pyaxmlparsersince thepyinstallerdocumentation states that it collects all submodules, data files, and binaries from the specified package or module.