Skip to content

Commit

Permalink
Build the sky resampling right into the sky subtraction so nobody eve…
Browse files Browse the repository at this point in the history
…r forgets to do it. The sky fiber should always be interpolated onto the science fiber's wavelength solution before sky subtraction, according to the HPF folks.
  • Loading branch information
Kyle Kaplan committed Sep 23, 2023
1 parent b3b1581 commit 4499827
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/muler/hpf.py
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ def sky_subtract(self, method="scalar", scale=0.93):
raise NotImplementedError

# These steps should propagate uncertainty?
sky_estimator = spec.sky.multiply(beta, handle_meta="first_found")
sky_estimator = spec.sky_resample().sky.multiply(beta, handle_meta="first_found")
return spec.subtract(sky_estimator, handle_meta="first_found")

def mask_tellurics(self, method="TelFit", threshold=0.999, dilation=5):
Expand Down

0 comments on commit 4499827

Please sign in to comment.