homework-08 #4
Merged
homework-08 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Действительно, есть ошибка при указании версии. |
Nklya
approved these changes
Dec 26, 2017
| public_key_path = "~/.ssh/appuser.pub" | ||
| private_key_path = "~/.ssh/appuser" | ||
| disk_image = "reddit-base" | ||
| gcp_provider_version = "1.4.0" |
There was a problem hiding this comment.
Это указывать не нужно, потому что версию параметризовать не получится.
| description = "Disk image" | ||
| } | ||
|
|
||
| variable gcp_provider_version { |
There was a problem hiding this comment.
Это указывать не нужно, потому что версию параметризовать не получится.
| sudo mv /tmp/puma.service /etc/systemd/system/puma.service | ||
| sudo systemctl daemon-reload | ||
| sudo systemctl start puma | ||
| sudo systemctl enable puma |
There was a problem hiding this comment.
У тебя в этом файле нет последней пустой линии. Советую настроить редактор на автом. добавление при сохранении.
Nklya
reviewed
Dec 26, 2017
| ## Homework 08 | ||
|
|
||
| Задание со звездочкой 1 | ||
| Для добавления ssh ключей в проект нужно воспользоваться ресурсом ```google_compute_project_metadata``` |
There was a problem hiding this comment.
Можно еще использовать google_compute_project_metadata_item, т.к. мы все равно добавляем только одну пару key:value
There was a problem hiding this comment.
спасибо
и правда так удобнее было бы
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Выолнено домашнее задание 8.
В ходе выполнения была найдена ошибка в последней версии terraform
При использовании переменной для указания версии провайдера terraform падает с ошибкой.
Подробней можно посмотреть тут:
hashicorp/terraform#15742
Данная ошибка уже исправленна, но еще нет релиза с этим исправлением