-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make invalid credentials less informative #59
Comments
@huard : We discussed about that in a meeting (see ref) and we agreed that telling specifically that a user doesn't exist could be exploited. The good practice is to tell that a user/password combinaison isn't correct. This way someone cannot guess first a valid user and then guess it's password. If you want to see that in action try to log to github with an invalid username. It will never let you know that this user doesn't exist. |
Got it. As long as the message is clear, I'm good. E.g "Your login information is incorrect, check your username and password." |
resolved via PR #64 |
As discussed in meeting: https://www.crim.ca/confluence/pages/viewpage.action?pageId=21761637
The text was updated successfully, but these errors were encountered: