Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some functions taking a user as argument #158

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Conversation

davidcaron
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 26, 2019

Codecov Report

Merging #158 into master will decrease coverage by 0.07%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage    68.3%   68.23%   -0.08%     
==========================================
  Files          97       98       +1     
  Lines        6857     8906    +2049     
==========================================
+ Hits         4684     6077    +1393     
- Misses       2173     2829     +656
Impacted Files Coverage Δ
magpie/api/management/user/user_views.py 70.72% <0%> (-11.29%) ⬇️
magpie/api/management/user/user_utils.py 86.99% <50%> (+0.43%) ⬆️
magpie/api/management/service/service_views.py 77.77% <0%> (-19.79%) ⬇️
magpie/api/management/group/group_formats.py 81.81% <0%> (-18.19%) ⬇️
magpie/api/management/service/service_utils.py 60.34% <0%> (-18.04%) ⬇️
magpie/api/management/service/service_formats.py 79.54% <0%> (-17.43%) ⬇️
magpie/api/management/group/group_utils.py 58.38% <0%> (-15.62%) ⬇️
magpie/ui/management/views.py 42.33% <0%> (-5.8%) ⬇️
magpie/definitions/typedefs.py 6.97% <0%> (-3.03%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a2386...0a3181c. Read the comment docs.

Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typing

magpie/api/management/user/user_utils.py Show resolved Hide resolved
@fmigneault
Copy link
Collaborator

@davidcaron
Re-triggered tests now working

@fmigneault fmigneault merged commit a1ac548 into master Mar 29, 2019
@fmigneault fmigneault deleted the fix_user_id branch March 29, 2019 00:29
@fmigneault fmigneault mentioned this pull request Mar 29, 2019
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants