Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #209 #213

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Issue #209 #213

merged 2 commits into from
Sep 5, 2019

Conversation

ChaamC
Copy link
Contributor

@ChaamC ChaamC commented Sep 4, 2019 •
edited by fmigneault
Loading

Fixed issue where pressing return when editing user password deletes the user completely
Fixed similar issue found on the Groups and Services pages

64028952-a84cd180-cb11-11e9-99c8-a9e2895f32bd

Fixes #209

@codecov-io
Copy link

codecov-io commented Sep 4, 2019 •
edited
Loading

Codecov Report

Merging #213 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #213   +/-   ##
======================================
  Coverage    71.6%   71.6%           
======================================
  Files          95      95           
  Lines        6891    6891           
======================================
  Hits         4934    4934           
  Misses       1957    1957

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a9fb97...fb4fb1d. Read the comment docs.

fmigneault
fmigneault approved these changes Sep 4, 2019
View reviewed changes
Copy link
Collaborator

@fmigneault fmigneault left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Waiting for Travis to validate everything.

@fmigneault fmigneault added the ui Something related to the UI operations or display label Sep 4, 2019
dbyrns
dbyrns approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

davidcaron
davidcaron reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@davidcaron davidcaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fmigneault fmigneault merged commit d888db1 into master Sep 5, 2019
@fmigneault fmigneault deleted the issue_#209 branch September 5, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmigneault fmigneault fmigneault approved these changes

@davidcaron davidcaron davidcaron approved these changes

@dbyrns dbyrns dbyrns approved these changes

Assignees
No one assigned
Labels
ui Something related to the UI operations or display
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pressing return when editing user password deletes the user completely
6 participants
@ChaamC @codecov-io @dbyrns @davidcaron @fmigneault @cwcummings