Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission extensions #363

Merged
merged 23 commits into from
Oct 29, 2020
Merged

Permission extensions #363

merged 23 commits into from
Oct 29, 2020

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Oct 23, 2020

Depends on #353 (rebased).

Fixes #157
Fixes #234
Fixes #361

@fmigneault fmigneault requested a review from dbyrns October 23, 2020 21:33
@github-actions github-actions bot added api Something related to the API operations ci Something related to code tests, deployment and packaging db Issues related to database connection, migration or data models doc Documentation improvements or building problem plugin Service plugin tests Test execution or additional use cases ui Something related to the UI operations or display labels Oct 23, 2020
@fmigneault fmigneault force-pushed the permission-extensions branch from 5ce4fdb to 293a670 Compare October 26, 2020 17:28
@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #363 into master will increase coverage by 5.53%.
The diff coverage is 85.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   68.91%   74.44%   +5.53%     
==========================================
  Files          65       65              
  Lines        7009     7463     +454     
  Branches      950     1032      +82     
==========================================
+ Hits         4830     5556     +726     
+ Misses       1961     1656     -305     
- Partials      218      251      +33     
Impacted Files Coverage Δ
magpie/adapter/__init__.py 49.52% <ø> (+49.52%) ⬆️
magpie/adapter/magpieservice.py 36.53% <ø> (+36.53%) ⬆️
magpie/ui/utils.py 70.00% <ø> (ø)
magpie/register.py 28.12% <24.00%> (+1.08%) ⬆️
magpie/adapter/magpieowssecurity.py 67.16% <50.00%> (+67.16%) ⬆️
magpie/api/management/resource/resource_utils.py 75.80% <50.00%> (ø)
magpie/ui/user/views.py 62.50% <50.00%> (ø)
magpie/models.py 92.63% <66.66%> (+2.90%) ⬆️
magpie/services.py 75.81% <76.66%> (+30.39%) ⬆️
magpie/ui/management/views.py 46.38% <81.63%> (+4.66%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d535d...f96fbc3. Read the comment docs.

@fmigneault fmigneault changed the base branch from master to permissions-scheme October 26, 2020 21:25
Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I only got some small questions and suggestions.

docs/services.rst Show resolved Hide resolved
docs/services.rst Show resolved Hide resolved
docs/services.rst Show resolved Hide resolved
docs/services.rst Show resolved Hide resolved
docs/services.rst Outdated Show resolved Hide resolved
docs/services.rst Show resolved Hide resolved
magpie/services.py Show resolved Hide resolved
magpie/services.py Outdated Show resolved Hide resolved
@fmigneault fmigneault mentioned this pull request Oct 28, 2020
15 tasks
Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's fine with me! Thank you.

@fmigneault
Copy link
Collaborator Author

@dbyrns redeployed on ogc-ades

@fmigneault fmigneault force-pushed the permission-extensions branch from 5cabd1b to 1322770 Compare October 29, 2020 17:18
Base automatically changed from permissions-scheme to master October 29, 2020 17:21
@fmigneault fmigneault merged commit cb82aef into master Oct 29, 2020
@fmigneault fmigneault deleted the permission-extensions branch October 29, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Something related to the API operations ci Something related to code tests, deployment and packaging db Issues related to database connection, migration or data models doc Documentation improvements or building problem plugin Service plugin tests Test execution or additional use cases ui Something related to the UI operations or display
Projects
None yet
3 participants