-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix alignment of permission title/combobox #501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a nice addition to store the scrolling position.
If my understanding is correct the tooltip apply to the ressources, but it would be really usefull for the permission title too when there is an overflow and ellipsis is applied.
I will let @f-PLT makes the final approval after he checks the rendering.
Code looks good to me, and rendering worked as expected on Firefox and Chrome on my end. |
Doesn't it display a scrollbar when the title is too large? That's what it is supposed to do. |
Didn't test it. |
I did a quick test with CSS in an editor, the lack of Actually replacing with Anyway, I think that once a full length horizontal scrollbar is available for permissions (as is cited in #498), the columns could also be widened so the full title is visible for all columns. |
Changes / Fixes
Resource
ID to elements rendered in theService
andPermission
hierarchy trees(relates to [Feature] Add tooltip details to some items #335).
(relates to Update UI to handle many permissions wider than available display width #498).