Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix alignment of permission title/combobox #501

Merged
merged 5 commits into from
Feb 1, 2022
Merged

Conversation

fmigneault
Copy link
Member

Changes / Fixes

@fmigneault fmigneault requested review from dbyrns and f-PLT February 1, 2022 06:41
@fmigneault fmigneault self-assigned this Feb 1, 2022
@fmigneault fmigneault added enhancement Improvements in term of performance or behaviour ui Something related to the UI operations or display labels Feb 1, 2022
@github-actions github-actions bot added the doc Documentation improvements or building problem label Feb 1, 2022
Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a nice addition to store the scrolling position.
If my understanding is correct the tooltip apply to the ressources, but it would be really usefull for the permission title too when there is an overflow and ellipsis is applied.
I will let @f-PLT makes the final approval after he checks the rendering.

@f-PLT
Copy link

f-PLT commented Feb 1, 2022

Code looks good to me, and rendering worked as expected on Firefox and Chrome on my end.

@fmigneault
Copy link
Member Author

@dbyrns

for the permission title too when there is an overflow and ellipsis is applied.

Doesn't it display a scrollbar when the title is too large? That's what it is supposed to do.

@dbyrns
Copy link
Contributor

dbyrns commented Feb 1, 2022

Doesn't it display a scrollbar when the title is too large? That's what it is supposed to do.

Didn't test it. text-overflow: ellipsis; for me is used when ... replace the text that don't fit it the space. Fine with me if a scrollbar is available and all the permission can be read.

@f-PLT
Copy link

f-PLT commented Feb 1, 2022

Doesn't it display a scrollbar when the title is too large? That's what it is supposed to do.

Didn't test it. text-overflow: ellipsis; for me is used when ... replace the text that don't fit it the space. Fine with me if a scrollbar is available and all the permission can be read.

I did a quick test with CSS in an editor, the lack of ... could be related to display: inline-flex; in the permission-cell class, as they are applied to the same divs.

Actually replacing with ... could make it confusing for people who are not familiar with the operations in question (unless a tooltip or other way to see the full name is available)

Anyway, I think that once a full length horizontal scrollbar is available for permissions (as is cited in #498), the columns could also be widened so the full title is visible for all columns.

@fmigneault fmigneault merged commit 6940c7e into master Feb 1, 2022
@fmigneault fmigneault deleted the fix-ui-perms branch February 1, 2022 18:19
@fmigneault
Copy link
Member Author

For documentation purpose, the tooltip in question:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation improvements or building problem enhancement Improvements in term of performance or behaviour ui Something related to the UI operations or display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants