Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023 Updates #20

Merged
merged 13 commits into from
Jun 7, 2023
Merged

2023 Updates #20

merged 13 commits into from
Jun 7, 2023

Conversation

Zeitsperre
Copy link

@Zeitsperre Zeitsperre commented May 18, 2023

Changes

  • Removed .travis.yml
  • Updated documentation building in Makefile
  • Updated pre-commit hooks
  • Updated dev dependencies
  • Updated actions used for testing bake setup
  • Added Issue Templates
  • Added GitHub Workflows to the recipe
  • Added a Zenodo configuration
  • Updated license identifiers to use SPDX conventions.
  • Fix some issues with spacing.

What is not changed (but should be)

  • We should eventually adopt pyproject.toml (with flit) in this recipe and dropping setup.py

Other comments

The engine being used to test all this is largely unmaintained, hence why I needed to reduce the number of builds. From what I can see, generating (baking) the recipe works fine from most Python versions, but the testing utilities are not compatible with newer Python versions. Oh well.

… pre-commit hooks, update dev dependencies, update actions, fix some issues with spacing
@Zeitsperre Zeitsperre added documentation Improvements or additions to documentation enhancement New feature or request labels May 18, 2023
@Zeitsperre Zeitsperre self-assigned this May 18, 2023
@Zeitsperre Zeitsperre requested a review from tlvu June 2, 2023 17:47
Copy link

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments.

.github/workflows/main.yml Show resolved Hide resolved
{{cookiecutter.project_slug}}/MANIFEST.in Outdated Show resolved Hide resolved
{{cookiecutter.project_slug}}/Makefile Outdated Show resolved Hide resolved
{{cookiecutter.project_slug}}/Makefile Outdated Show resolved Hide resolved
{{cookiecutter.project_slug}}/setup.py Show resolved Hide resolved
{{cookiecutter.project_slug}}/tox.ini Show resolved Hide resolved
@Zeitsperre Zeitsperre merged commit 49c15f3 into master Jun 7, 2023
@Zeitsperre Zeitsperre deleted the updates_2023 branch June 7, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants