Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cowbird services to handlers #22

Closed
ChaamC opened this issue Jun 16, 2022 · 1 comment · Fixed by #23
Closed

Refactor cowbird services to handlers #22

ChaamC opened this issue Jun 16, 2022 · 1 comment · Fixed by #23
Assignees
@ChaamC

Comments

@ChaamC
Copy link
Contributor

ChaamC commented Jun 16, 2022 •
edited
Loading

In the cowbird config, the first services section is confusing with the services term already used for Magpie.
A suggestion would be to rename the first services section to handlers. Note that there are many other services references that should be consequently refactored in cowbird (for example the cowbird/services folder, and everything it contains, cowbird/api/services, cowbird/cli/services.py, ...).
@github-actions
Copy link

Thanks for submitting an issue. Make sure you have checked for similar issues. Also, provide enough details for us to be able to replicate the problem.

@ChaamC ChaamC mentioned this issue Jun 16, 2022
Merged
@fmigneault fmigneault changed the title Refactor cowbird services to `handlers Refactor cowbird services to handlers Jun 16, 2022
@ChaamC ChaamC self-assigned this Aug 16, 2022
@fmigneault fmigneault mentioned this issue Aug 16, 2022
Merged
4 tasks
@ChaamC ChaamC linked a pull request Aug 17, 2022 that will close this issue
22 refactor cowbird services to handlers #23
Merged
fmigneault added a commit to bird-house/birdhouse-deploy that referenced this issue Aug 18, 2022
@fmigneault
bump cowbird 0.5.0 -> 1.0.0 with handlers refactor (relates to Ourano…
3b78a48 
…sinc/cowbird#22)
fmigneault added a commit to bird-house/birdhouse-deploy that referenced this issue Aug 18, 2022
@fmigneault
bump cowbird 0.5.0 -> 1.0.0 with handlers refactor (relates to Ourano…
6cb596a 
…sinc/cowbird#22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChaamC ChaamC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

22 refactor cowbird services to handlers Ouranosinc/cowbird
1 participant
@ChaamC