Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure refresh_user still works before user state has been persisted to db #23

Merged
merged 1 commit into from
Nov 27, 2023
Merged

ensure refresh_user still works before user state has been persisted to db #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions jupyterhub_magpie_authenticator/jupyterhub_magpie_authenticator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,11 @@ async def authenticate(self, handler, data):
return data['username']

async def refresh_user(self, user, handler=None):
if not (self.authorization_url and self.enable_auth_state):
# MagpieAuthenticator is not configured to re-check user authorization
return True
auth_state = await user.get_auth_state()
if auth_state is None:
# MagpieAuthenticator is not configured to re-check user authorization or the auth state
# has not been persisted to the database yet.
return True
cookies = auth_state.get("magpie_cookies")
if cookies:
auth_response = requests.get(self.authorization_url, cookies=cookies)
Expand Down