-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subset-user-input.ipynb: fix output for Thredds v5 #317
base: master
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@tlogan2000 is |
It's not the same data no |
So it is not expected that with the new Thredds v5, |
@tvlu THREDDS sorting of datasets seems to have changed between v4 and v5. Two options to fix.
or
to
should ensure that v2 is found instead of v1 |
Is there an access by name instead of by index? Otherwise, the day we have Also, whether we choose |
for more information, see https://pre-commit.ci
Nothing built in but I change the code to search for |
Super, I'd do a "refresh" with Thredds v5 and test against our current Thredds v4. If it works, we can merge this immediately and be forward compatible with Thredds v5 ! |
Only merge if bird-house/birdhouse-deploy#413 can be merged.
This is mostly to have a nice notebook diff.