Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebooks: refresh output for Jenkins #389

Closed
wants to merge 8 commits into from

Conversation

tlvu
Copy link
Contributor

@tlvu tlvu commented May 20, 2021

Overview

Trying to get Raven notebooks to pass Jenkins without --nbval-lax since we have disabled by default comparing html and javascript outputs, see PR Ouranosinc/PAVICS-e2e-workflow-tests#73

Changes:

  • A run of make refresh-notebooks

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Zeitsperre
Copy link
Contributor

@tlvu I think this should be the last PR before we rename Raven -> RavenWPS. Think you could verify that the "refreshed" notebooks are working on Jenkins?

@huard
Copy link
Contributor

huard commented Sep 8, 2021

Is there any actual code change here or this is just a refresh ?

@tlvu
Copy link
Contributor Author

tlvu commented Sep 8, 2021

Pretty sure I only did a refresh, no code change. That's why it was in draft mode. I was not fully ready to merge it yet. I intended to make a few code change to get Jenkins to pass. Just ignore this for now if you need to make code change. I'll refresh again later when I can continue on this.

@huard huard closed this Nov 8, 2021
@Zeitsperre Zeitsperre deleted the refresh-notebooks-for-jenkins branch November 8, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants