-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Data Tagging #1339
Merged
Merged
Testing Data Tagging #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No further action is required. |
19 tasks
aulemahal
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Approved for additional tests
CI
Automation and Contiunous Integration
docs
Improvements to documenation
priority
Immediate priority
standards / conventions
Suggestions on ways forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
pytest
to ensure thatxclim-testdata
branches used to test againstxclim
are compatible.main.yml
CI workflow to use tagged commits fromxclim-testdata
main.yml
is consistent with the latest tag inxclim-testdata
, and posts comments and/or fails the build if there is disagreement. This is only triggered if changes are made tomain.yml
xclim-testdata
.Does this PR introduce a breaking change?
Yes.
XCLIM_TESTDATA_BRANCH
now points to tagged testing data commits on CI.Other information: