Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
xclim.core.missing.MissingBase.prepare
, we transform nanoseconds into days. Pandas' timedelta doesn't support it anymore, but we only need the array, so I passed through numpy directly instead.xclim.sdba.base.Grouper.get_index
, we relied on the deprecatedDatetimeIndex.dt.week
, here I used the suggestedDatetimeIndex.dt.isocalendar().week
instead.equals
test in themake_criteria
unittest, it wasn't necessary and failed because of the changed dim order.xclim v0.42.0
will be the last version to explicitly support Python3.8.Does this PR introduce a breaking change?
It shouldn't. This should be completely compatible with pandas 1.5 and a few earlier releases.
Other information:
#1268