Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add measure to yaml indicator description #1664

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Feb 21, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Add measure to yaml indicator description. This is a argument that can be given to properties.

Does this PR introduce a breaking change?

no

Other information:

Without this addition, xscen documentation fails.

@github-actions github-actions bot added the indicators Climate indices and indicators label Feb 21, 2024
@aulemahal
Copy link
Collaborator

I added the possibility to skip the validation or to have a custom schema.
So I'll defer the review to someone else.

@aulemahal aulemahal requested review from huard and removed request for aulemahal February 21, 2024 22:14
@Zeitsperre Zeitsperre added the priority Immediate priority label Feb 22, 2024
@Zeitsperre
Copy link
Collaborator

This PR addresses a significant bug in some downstream libraries. We'll be releasing a patch (0.48.2) after this is merged.

@github-actions github-actions bot added the approved Approved for additional tests label Feb 26, 2024
@coveralls
Copy link

Coverage Status

coverage: 90.193% (+0.003%) from 90.19%
when pulling aadb084 on fix-yamale-measure
into 43612e3 on master.

@Zeitsperre
Copy link
Collaborator

@juliettelavoie Merge when ready!

@juliettelavoie juliettelavoie merged commit 5530daf into master Feb 26, 2024
19 checks passed
@juliettelavoie juliettelavoie deleted the fix-yamale-measure branch February 26, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests indicators Climate indices and indicators priority Immediate priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants