Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix linting issues raised from new pylint and codespell versions #1772

Merged
merged 5 commits into from
Jun 10, 2024
Merged

fix linting issues raised from new pylint and codespell versions #1772

merged 5 commits into from
Jun 10, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jun 7, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Fixes new errors raised from the newer versions of pylint and codespell
  • Sets the doctest examples to all use h5netcdf with separate caches to load datasets

Does this PR introduce a breaking change?

No.

Other information:

https://pypi.org/project/pylint/3.2.3/
https://pypi.org/project/codespell/2.3.0/

@github-actions github-actions bot added sdba Issues concerning the sdba submodule. indicators Climate indices and indicators labels Jun 7, 2024
@Zeitsperre Zeitsperre requested a review from aulemahal June 7, 2024 20:43
@github-actions github-actions bot added the approved Approved for additional tests label Jun 10, 2024
@Zeitsperre Zeitsperre merged commit 1f4b4da into pre-commit-ci-update-config Jun 10, 2024
18 of 19 checks passed
@Zeitsperre Zeitsperre deleted the fix-linting branch June 10, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests indicators Climate indices and indicators sdba Issues concerning the sdba submodule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @aulemahal