Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address scalar/dimension concatenation error #1780

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Address scalar/dimension concatenation error #1780

merged 3 commits into from
Jun 17, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jun 13, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Fixes a previously uncaught error where remnants of a scenario selection were not being dropped properly.

Does this PR introduce a breaking change?

No.

@Zeitsperre Zeitsperre added the bug Something isn't working label Jun 13, 2024
@Zeitsperre Zeitsperre self-assigned this Jun 13, 2024
@Zeitsperre Zeitsperre requested a review from coxipi June 13, 2024 19:23
coxipi
coxipi approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@coxipi coxipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@github-actions github-actions bot added the approved Approved for additional tests label Jun 17, 2024
@Zeitsperre Zeitsperre changed the base branch from main to pin-numpy June 17, 2024 14:50
@Zeitsperre Zeitsperre merged commit 61ca7a8 into pin-numpy Jun 17, 2024
18 of 19 checks passed
@Zeitsperre Zeitsperre deleted the fix-concat-hist branch June 17, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coxipi coxipi coxipi approved these changes

@aulemahal aulemahal Awaiting requested review from aulemahal

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @coxipi