Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin netcdf4 #1791

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Pin netcdf4 #1791

merged 2 commits into from
Jun 25, 2024

Conversation

Zeitsperre
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Pins the netcdf4 library as it is causing issues in tests and notebooks

Does this PR introduce a breaking change?

No.

Other information:

@Zeitsperre Zeitsperre changed the title Pin-netcdf4 Pin netcdf4 Jun 20, 2024
@Zeitsperre Zeitsperre self-assigned this Jun 20, 2024
@Zeitsperre Zeitsperre added bug Something isn't working dependencies Pull requests that update a dependency file labels Jun 20, 2024
@Zeitsperre Zeitsperre requested a review from a team June 20, 2024 21:29
coxipi
coxipi approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@coxipi coxipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@github-actions github-actions bot added the approved Approved for additional tests label Jun 20, 2024
@Zeitsperre Zeitsperre merged commit cf3316d into ouranos-helper-bot Jun 25, 2024
18 of 19 checks passed
@Zeitsperre Zeitsperre deleted the pin-netcdf4 branch June 25, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coxipi coxipi coxipi approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @coxipi