Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional checks for PWM fit existing values #1850

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Add additional checks for PWM fit existing values #1850

merged 3 commits into from
Jul 31, 2024

Conversation

saschahofmann
Copy link
Contributor

@github-actions GitHub Actions
Copy link

Warning

This Pull Request is coming from a fork and must be manually tagged approved in order to perform additional testing.

VascoSch92
VascoSch92 reviewed Jul 30, 2024
View reviewed changes
xclim/indices/stats.py Outdated Show resolved Hide resolved
saschahofmann and others added 2 commits July 31, 2024 16:26
@saschahofmann @VascoSch92
Update comment for PWM method in fifunc_1d
be9bee9 
Co-authored-by: Vasco Schiavo <115561717+VascoSch92@users.noreply.github.com>
@saschahofmann
Merge branch 'main' into fix-fitfun1d-pwm
d5095e5
aulemahal
aulemahal approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it and this is a good idea. Thanks!

@coveralls
Copy link

Coverage Status

coverage: 90.412% (-0.008%) from 90.42%
when pulling d5095e5 on saschahofmann:fix-fitfun1d-pwm
into 7e4f7d9 on Ouranosinc:main.

@aulemahal aulemahal merged commit bde2685 into Ouranosinc:main Jul 31, 2024
26 checks passed
@saschahofmann saschahofmann deleted the fix-fitfun1d-pwm branch July 31, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VascoSch92 VascoSch92 VascoSch92 left review comments

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

indices.stats.fit fails for PWM with less than dist.numargs +2 values
4 participants
@saschahofmann @coveralls @aulemahal @VascoSch92