Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow optimisations #1859

Merged
merged 18 commits into from
Aug 1, 2024
Merged

Workflow optimisations #1859

merged 18 commits into from
Aug 1, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jul 31, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • tox-gh has been configured to set tox environments on GitHub Workflows
  • The tox.ini file is a bit more organized/consistent.
  • upstream.yml was adapted to not use hashes (impossible to install directly from GitHub sources using --require-hashes).

Does this PR introduce a breaking change?

No. Tests on GitHub have been changed around a bit, but the coverage should be unaffected. Preliminary tests now skip the slow tests.

@Zeitsperre Zeitsperre self-assigned this Jul 31, 2024
Copy link

Note

It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2023.12.14).

No further action is required.

@github-actions github-actions bot added the CI Automation and Contiunous Integration label Jul 31, 2024
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

@github-actions github-actions bot added the approved Approved for additional tests label Jul 31, 2024
@github-actions github-actions bot added information For development/intsructional purposes docs Improvements to documenation labels Jul 31, 2024
@Zeitsperre
Copy link
Collaborator Author

Sorry to ask for a re-review. Will be performing a squash+merge to not pollute the git history.

@Zeitsperre Zeitsperre merged commit 32fe937 into main Aug 1, 2024
38 checks passed
@Zeitsperre Zeitsperre deleted the workflow-optimisations branch August 1, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration docs Improvements to documenation information For development/intsructional purposes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants